Skip to content

add simple test illustrating hashchange event breakage#59

Open
ahamid wants to merge 1 commit intodevote:masterfrom
ahamid:hashchange_test
Open

add simple test illustrating hashchange event breakage#59
ahamid wants to merge 1 commit intodevote:masterfrom
ahamid:hashchange_test

Conversation

@ahamid
Copy link

@ahamid ahamid commented Jun 21, 2014

I believe this test demonstrates that the standard hashchange event is broken.

In onHashChangeEvent, fireNow and lastURL values are different, and appear to capture the last [sic] and next [sic] hash values.

function onHashChange(event) {
 // https://github.com/devote/HTML5-History-API/issues/46
 var fireNow = lastURL;
 // new value to lastURL
 lastURL = windowLocation.href;

e..g

> fireNow
"file:///home/user/workspace/HTML5-History-API/test/test_hashchange_html5.html"
> lastURL
"file:///home/user/workspace//HTML5-History-API/test/test_hashchange_html5.html#/path"

however, later, the lastURL and newURL values are compared, and they are identical

var oldURLObject = parseURL(lastURL, true);
var newURLObject = parseURL();
...
if (oldURLObject._hash !== newURLObject._hash) {
  // if current hash not equal previous hash
  dispatchEvent(event);
}

and the event is never fired.

@devote
Copy link
Owner

devote commented Jun 21, 2014

Hi,

Thank you very much for pointing out the error. This I did not complete the problem associated with #46

Now I fixed the problem and now it should work fine.

devote added a commit that referenced this pull request Jun 21, 2014
@devote
#59 standard hashchange event is broken
9f16701
@devote devote added the bug label Jun 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahamid @devote